ci: replace msvc-dev-cmd with WIP vanilla bat - #409
Open
VJanKraemer wants to merge 2 commits into
Open
Conversation
VJanKraemer
force-pushed
the
remove_msvc_cmd
branch
from
August 20, 2026 06:34
cd38883 to
9a303d8
Compare
|
|
||
| new_env = vsdevcmd_proc.stdout | ||
| logger.debug(f"New Env:\n{new_env}") | ||
| logger.debug(f"Old End: \n{json.dumps(dict(os.environ), indent=2)}") |
Member
There was a problem hiding this comment.
Suggested change
| logger.debug(f"Old End: \n{json.dumps(dict(os.environ), indent=2)}") | |
| logger.debug(f"Old Env: \n{json.dumps(dict(os.environ), indent=2)}") |
| def find_VsDevCmd() -> str: | ||
|
|
||
| some_out = subprocess.run( | ||
| ["vswhere", "-version", "[17.0, 17.9)", "-property", "InstallationPath"], |
Member
There was a problem hiding this comment.
This should result in the absolute path to the VsDevCmd.bat file directly:
Suggested change
| ["vswhere", "-version", "[17.0, 17.9)", "-property", "InstallationPath"], | |
| ["vswhere", "-latest", "-find", "Common7\Tools\VsDevCmd.bat"], |
Comment on lines
+32
to
+34
| vs_path = find_VsDevCmd() | ||
|
|
||
| vsdevcmd_path = vs_path / r'Common7\Tools\VsDevCmd.bat' |
Member
There was a problem hiding this comment.
Suggested change
| vs_path = find_VsDevCmd() | |
| vsdevcmd_path = vs_path / r'Common7\Tools\VsDevCmd.bat' | |
| vsdevcmd_path = find_VsDevCmd() |
| logger.error("Could not acquire a new shell env!") | ||
| exit(1) | ||
|
|
||
| environment = json.loads(vsdevcmd_proc.stdout) |
Member
There was a problem hiding this comment.
Before 'publishing' the new environment to GITHUB_ENV, we should filter out any environment variable starting with GITHUB_, RUNNER_, and the CI variable.
VJanKraemer
force-pushed
the
remove_msvc_cmd
branch
2 times, most recently
from
August 20, 2026 13:35
e0b3d0b to
a2db728
Compare
In order to minimize 3rd party dependencies we replaced the msvc-dev-cmd action with a python script. Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
VJanKraemer
force-pushed
the
remove_msvc_cmd
branch
from
August 20, 2026 13:42
a2db728 to
3107ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
redudece third party dependencies in CI
Description
msvc-dev-cmd is the only (non github) third party depency we have in our CI. And while not critical we want to experiment with vanilla setups for the CI
Instructions for review / testing
Developer checklist (address before review)